Remove django guardian from querysets #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set these permissions when we save a project or a version https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/projects/models.py#L424-L425 https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/builds/models.py#L249-L250 We set them to all the owners of a project, we already know all projects of an user with `user.projects`. For now I'm just removing guardian from the querysets, in another PR I'm going to remove the dep of guardian
|
I triggered a couple of builds locally, nothing broken so far |
|
Got a duplicated :/ |
stsewd
removed
the
PR: work in progress
|
Wasn't able to remove the distinct call, but I have other ideas, but in another PR after this. |
stsewd
commented
Jun 27, 2019
| @@ -91,9 +91,9 @@ def _add_user_repos(self, queryset, user=None): | |||
| if user.has_perm('builds.view_version'): | |||
There was a problem hiding this comment.
btw, we don't set this in any part of the code, so I guess this can only be done in the db, but again, I don't think we do that or want to do that.
|
I didn't see so much changes in the number of queries, actually the number of queries got reduced in the project dashboard page |
|
There's also this, but I think it is the same as the project save: |
|
Yeah, it's the same, it adds another user to the project-user relationship |
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this pull request
Jun 27, 2019
This is related to readthedocs#5853
ericholscher
approved these changes
Jun 27, 2019
|
Let's not break the internet 🤞 |
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this pull request
Jun 27, 2019
This is related to readthedocs#5853
|
Tested this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set these permissions when we save a project or a version
https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/projects/models.py#L424-L425
https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/builds/models.py#L249-L250
We set them to all the owners of a project,
we already know all projects of an user with
user.projects.For now I'm just removing guardian from the querysets,
in another PR I'm going to remove the dep of guardian
This also removes the use of(This failed, I'm keeping distinct :/)distinct(this generates problems when trying to do another or|)